Skip to content

fix(examples): s2 dialog's weren't closing #7219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

ktabors
Copy link
Member

@ktabors ktabors commented Oct 22, 2024

fix from testing

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

run the test apps
Click the "Check connectivity" button to open dialog
close the dialog

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Oct 22, 2024

@snowystinger
Copy link
Member

snowystinger commented Oct 22, 2024

Ah, the render props was actually a breaking change. It was too hard to notice the curly braces... I think we'll need to revert that change or handle it a different way

EDIT: wait, how did these examples ever work? It was always an object that needed to be destructured? https://github.com/adobe/react-spectrum/pull/7189/files#diff-b5d43ddb3fb3c60899237d3fb92ae8eb8feef8174beffdcac4592ee86e0b7eddL82

Ok, I confirmed, this was broken prior to the recent Dialog / renderProps PR

@ktabors
Copy link
Member Author

ktabors commented Oct 22, 2024

EDIT: wait, how did these examples ever work? It was always an object that needed to be destructured? https://github.com/adobe/react-spectrum/pull/7189/files#diff-b5d43ddb3fb3c60899237d3fb92ae8eb8feef8174beffdcac4592ee86e0b7eddL82

I'm not sure it ever worked. I think we missed this that this was broken during previous testing. The storybook example does the object destructuring, which was how I figured out what was wrong.

@ktabors ktabors added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit a56a735 Oct 23, 2024
30 checks passed
@ktabors ktabors deleted the s2-example-dialog-close branch October 23, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants