Skip to content

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Oct 15, 2024

Reported in slack

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Go to S2 table and test it when isQuiet and you scroll the row contents to the right. The text should not peek out from behind the checkbox

🧢 Your Project:

RSP

cant use transparent for the default quiet row state, need a opaque color to hide scrolled text
@LFDanLu LFDanLu changed the title Mask the contents of a scrolled row for a quiet table Mask the contents of a non-selected scrolled row for a quiet table Oct 15, 2024
@rspbot
Copy link

rspbot commented Oct 15, 2024

@LFDanLu LFDanLu added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 0d0e21b Oct 15, 2024
29 checks passed
@LFDanLu LFDanLu deleted the table_quiet_mask_fix branch October 15, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants