Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) Autocomplete with menu #7181

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

(WIP) Autocomplete with menu #7181

wants to merge 31 commits into from

Commits on Oct 9, 2024

  1. scaffolding, copied Combobox and renamed to Autocomplete

    @LFDanLu
    LFDanLu committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c33ac96 View commit details
    Browse the repository at this point in the history

  2. get listbox rendering by default without open state

    @LFDanLu
    LFDanLu committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a185473 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. update intl file and more clean up to get rid of combobox stuff

    @LFDanLu
    LFDanLu committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e6fa7c1 View commit details
    Browse the repository at this point in the history

  2. fix lint

    @LFDanLu
    LFDanLu committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    61aab83 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. rough working version of Menu instead of Listbox in autocomplete 

    issues outlined in various comments, basically boils down to ideally using the wrapped collection components state
    @LFDanLu
    LFDanLu committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    66fecc8 View commit details
    Browse the repository at this point in the history

  2. fix submenu

    @LFDanLu
    LFDanLu committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    779309b View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Update autocomplete to have the wrapped menu filter itself

    @LFDanLu
    LFDanLu committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    78de7f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. fix keyboard interactions, and clean up 

    ended up going with dispatching events to the menu/menuitem so we can piggyback off of useSelectableCollection and menus press handling for submenutriggers, onAction, and link handling
    @LFDanLu
    LFDanLu committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e0f098a View commit details
    Browse the repository at this point in the history

  2. fix menu, add more stories, fix strict

    @LFDanLu
    LFDanLu committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5914d11 View commit details
    Browse the repository at this point in the history

  3. add announcements to menu and various clean up

    @LFDanLu
    LFDanLu committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    12480fd View commit details
    Browse the repository at this point in the history

  4. update yarn.lock

    @LFDanLu
    LFDanLu committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ad8942a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:adobe/react-spectrum into autocomplete

    @LFDanLu
    LFDanLu committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    70c2d0f View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. get rid of dom node in Autocomplete and fix readOnly bugs

    @LFDanLu
    LFDanLu committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9812c3c View commit details
    Browse the repository at this point in the history

  2. fix build failure

    @LFDanLu
    LFDanLu committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    8478937 View commit details
    Browse the repository at this point in the history

  3. test against popover experience

    @LFDanLu
    LFDanLu committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    3fbd35f View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. fix popover story

    @LFDanLu
    LFDanLu committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e15d999 View commit details
    Browse the repository at this point in the history

  2. properly clear aria-activedecendant

    @LFDanLu
    LFDanLu committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    368a677 View commit details
    Browse the repository at this point in the history

  3. cleanup

    @LFDanLu
    LFDanLu committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    82b3120 View commit details
    Browse the repository at this point in the history

  4. fix build

    @LFDanLu
    LFDanLu committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    423b73c View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Merge branch 'main' into autocomplete

    @LFDanLu
    LFDanLu authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6c498f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. properly focus trap the autocomplete popover

    @LFDanLu
    LFDanLu committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    fe5bfbe View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. update interaction pattern as per discussion 

    for now we will have first item auto focus, no custom announcements, and clear focus on backspace or arrow left/right. See https://docs.google.com/spreadsheets/d/12M--aeeNK4Kruzg8GnO7L-_DUsQE29_bWJzu4yI4-UA/edit?gid=1690380375#gid=1690380375 for a testing matrix
    @LFDanLu
    LFDanLu committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    477ca7f View commit details
    Browse the repository at this point in the history

  2. update yarn.lock

    @LFDanLu
    LFDanLu committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    9a58613 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. dont autofocus if user hasnt typed in the field yet

    @LFDanLu
    LFDanLu committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    574bd67 View commit details
    Browse the repository at this point in the history

  2. add delay for now to make NVDA announcement better

    @LFDanLu
    LFDanLu committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ae7a00f View commit details
    Browse the repository at this point in the history

  3. fix lint and scrap custom announcements 

    complications making the custom announcements for safari have a delay for when typing ahead but not when using the arrow keys to move through the options, so stashed it for now
    @LFDanLu
    LFDanLu committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    7b11c5d View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. intial tests

    @LFDanLu
    LFDanLu committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    04e8777 View commit details
    Browse the repository at this point in the history

  2. more tests and fixes to BaseCollection and keyboard interactions from… 

    … testing
    @LFDanLu
    LFDanLu committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    79c9064 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. fix lint and add RAC test

    @LFDanLu
    LFDanLu committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b20b626 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:adobe/react-spectrum into autocomplete

    @LFDanLu
    LFDanLu committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    28afe21 View commit details
    Browse the repository at this point in the history

  3. use MenuSection

    @LFDanLu
    LFDanLu committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2d0a15f View commit details
    Browse the repository at this point in the history