Update table resizer svg and bump tokens package #7154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will run chromatic soon, need to double check that the tokens bump is what we expect |
yihuiliao
reviewed
Oct 10, 2024
| positive: 'positive-700', | ||
| notice: 'notice-700', | ||
| negative: 'negative-800' | ||
| accent: lightDark('blue-800', 'blue-900'), // accent-visual-color |
There was a problem hiding this comment.
is there are reason why we aren't using 'accent-800'/'accent-900' instead? that would more closely match how they describe it in the token figma file
There was a problem hiding this comment.
good call! I'm not sure why I dove down an extra layer when getting the colors haha
yihuiliao
reviewed
Oct 11, 2024
| notice: 'notice-700', | ||
| negative: 'negative-800' | ||
| accent: lightDark('accent-800', 'accent-900'), // accent-visual-color | ||
| informative: lightDark('accent-800', 'accent-900'), // informative-visual-color |
There was a problem hiding this comment.
mega nit: i think this should be informative-800 and informative-900 instead of accent
snowystinger
previously approved these changes
Oct 14, 2024
reidbarber
previously approved these changes
Oct 14, 2024
yihuiliao
approved these changes
Oct 15, 2024
snowystinger
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP