-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add expanded boolean attribute to tailwind plugin #7152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
After testing out the new `Disclosure` components, I see that the tailwind plugin does not support styling the `expanded` state, leaving me to style using `data-[expanded]`. This PR adds `expanded` top the list of boolean states.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
You'll need to sign the CLA and close/re-open this for the build to pass.
Also, it would be great if you could add this to the snapshot tests at Beat me to it :)packages/tailwindcss-react-aria-components/src/index.test.js
. If you're having issues with that then no worries, we can add it.
@reidbarber thanks! Just done those |
Actually @reidbarber I think I'll need some help with the tests after all, if thats ok? I'm not fully understanding the failures |
@neefrehman I'll take a closer look. The tests seem to pass for me locally. It's likely a whitespace issue or something similar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a quick fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
After testing out the new
Disclosure
components, I see that the tailwind plugin does not support styling theexpanded
state, leaving me to style usingdata-[expanded]
. This PR addsexpanded
top the list of boolean states.Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: