Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useMove docs to be more clear when events start #6952

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix useMove docs to be more clear when events start #6952

wants to merge 1 commit into from
+2 −2

Conversation

snowystinger
Copy link
Member

Closes #4056

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Aug 27, 2024

Build successful! 🎉

@snowystinger snowystinger added this pull request to the merge queue Sep 1, 2024
@snowystinger snowystinger removed this pull request from the merge queue due to the queue being cleared Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbarber reidbarber reidbarber approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useMove: when is onMoveStart fired?
4 participants
@snowystinger @rspbot @reidbarber @yihuiliao