Fix Safari docs crash #6930
Merged
Fix Safari docs crash #6930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
commented
Aug 22, 2024
| window.addEventListener('load', () => listen()); | ||
| } | ||
|
|
||
| let raf = null; |
There was a problem hiding this comment.
this is just some defensive code
Closed
|
Nice one 🙌 Can confirm it fixed the issue for me |
reidbarber
approved these changes
Aug 22, 2024
LFDanLu
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5068
I was able to debug with my local build
We were getting into a state where the offsetWidth was within 1px of the scrollWidth, resulting in trying to make the font ever smaller since there was no guard against it getting too small/negative
The reason we were within 1px is that Safari seems to
floorclientWidth when other browsers doround, so I've added a + 1 to account for that. I tried using the bounding client rect and rounding myself, but for some reason, it sometime suffer from being a pixel off as well. So it may be a deeper rounding issue than I can account for.the + 1 discrepancy doesn't appear to harm anything and it was taking wayyyy too much of my time to try to fix it.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: