Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codemod: remove Section and Items imports if not used elsewhere in file #6908

Merged
merged 9 commits into from
Aug 22, 2024
Merged

Codemod: remove Section and Items imports if not used elsewhere in file #6908

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1d76772
remove Section or Items import if not used in file
reidbarber Aug 19, 2024
3af3bc6
check scope instead
reidbarber Aug 19, 2024
0033d0e
add new test
reidbarber Aug 19, 2024
679ca19
Merge branch 'main' into codemod-remove-items-sections-imports
reidbarber Aug 19, 2024
f5baae9
cleanup
reidbarber Aug 20, 2024
03febae
Merge branch 'main' into codemod-remove-items-sections-imports
reidbarber Aug 21, 2024
e367422
add extra test
reidbarber Aug 22, 2024
4f39c27
Merge branch 'codemod-remove-items-sections-imports' of https://githu…
reidbarber Aug 22, 2024
eb24843
Merge branch 'main' into codemod-remove-items-sections-imports
snowystinger Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup
  • Loading branch information
@reidbarber
reidbarber committed Aug 20, 2024
commit f5baae9a6b88b5ff44ee475690639fd6056e3f78
1 change: 0 additions & 1 deletion packages/dev/codemods/src/s1-to-s2/__tests__/__snapshots__/imports.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ import { StatusLight } from "@react-spectrum/s2";

exports[`should remove unused Item/Section import even if name taken in different scope 1`] = `
"import { MenuSection, MenuItem, Menu } from "@react-spectrum/s2";
import { ListBox } from '@adobe/react-spectrum';

function foo() {
let Item = 'something else';
Expand Down
4 changes: 2 additions & 2 deletions packages/dev/codemods/src/s1-to-s2/__tests__/imports.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,12 @@ import {Button} from "@react-spectrum/s2";
`);

test('should remove unused Item/Section import even if name taken in different scope', `
import {Menu, Section, Item, ListBox} from '@adobe/react-spectrum';
import {Menu, Section, Item} from '@adobe/react-spectrum';

function foo() {
let Item = 'something else';
let Section = 'something else';
}
}

<div>
<Menu aria-label="Text">
Expand Down