S2 taggroup collapse #6795
Merged
S2 taggroup collapse #6795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
force-pushed
the
s2-taggroup-collapse
branch
from
bb3c904 to
ced16b3
Compare
reidbarber
reviewed
Aug 9, 2024
# Conflicts: # packages/@react-spectrum/s2/src/TagGroup.tsx
devongovett
reviewed
Aug 14, 2024
LFDanLu
reviewed
Aug 15, 2024
There was a problem hiding this comment.
Just noticed that if you expand the taggroup wide enough when there is a max rows set that the "collapse" button and the group action button disappear, digging
EDIT: Ah it makes sense that the collapse/expand button disappear but the group action button shouldn't
LFDanLu
reviewed
Aug 15, 2024
|
|
||
| return { | ||
| visibleTagCount: Math.max(index, 1), | ||
| showCollapseButton: index < collection.size |
There was a problem hiding this comment.
Since the Collapse/Expand button and the groupAction button are in the same group, this logic makes combined with tagState.visibleTagCount < collection.size means that the groupAction button will be removed along side the collaspe/expand button if all the tags are visible.
Perhaps the group should always be rendered and showActions should instead hide the expand/collapse button from inside the group?
LFDanLu
reviewed
Aug 15, 2024
…m into s2-taggroup-collapse
…m into s2-taggroup-collapse
…m into s2-taggroup-collapse
ktabors
previously approved these changes
Aug 15, 2024
…up-collapse # Conflicts: # packages/@react-spectrum/s2/src/TagGroup.tsx
LFDanLu
approved these changes
Aug 15, 2024
## API Changes
@react-spectrum/s2TagGroup TagGroup <T extends {}> {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
children?: ReactNode | (T) => ReactNode
contextualHelp?: ReactNode
defaultSelectedKeys?: 'all' | Iterable<Key>
description?: ReactNode
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
errorMessage?: ReactNode
+ groupActionLabel?: string
id?: string
isEmphasized?: boolean
isInvalid?: boolean
items?: Iterable<T>
label?: ReactNode
labelAlign?: Alignment = 'start'
labelPosition?: LabelPosition = 'top'
+ maxRows?: number
+ onGroupAction?: () => void
onRemove?: (Set<Key>) => void
onSelectionChange?: (Selection) => void
renderEmptyState?: () => ReactNode
selectedKeys?: 'all' | Iterable<Key>
selectionMode?: SelectionMode
size?: 'S' | 'M' | 'L' = 'M'
slot?: string | null
styles?: StylesProp
}TagGroupProps TagGroupProps <T> {
UNSAFE_className?: string
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
children?: ReactNode | (T) => ReactNode
contextualHelp?: ReactNode
defaultSelectedKeys?: 'all' | Iterable<Key>
description?: ReactNode
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
errorMessage?: ReactNode
+ groupActionLabel?: string
id?: string
isEmphasized?: boolean
isInvalid?: boolean
items?: Iterable<T>
label?: ReactNode
labelAlign?: Alignment = 'start'
labelPosition?: LabelPosition = 'top'
+ maxRows?: number
+ onGroupAction?: () => void
onRemove?: (Set<Key>) => void
onSelectionChange?: (Selection) => void
renderEmptyState?: () => ReactNode
selectedKeys?: 'all' | Iterable<Key>
selectionMode?: SelectionMode
size?: 'S' | 'M' | 'L' = 'M'
slot?: string | null
styles?: StylesProp
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Added Taggroup Actions as well, it was pretty quick and small change
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: