fix(rac): Add TooltipWrapper support for Checkbox and Radio
#6738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vovsemenv
changed the title
Checkbox and Radio
vovsemenv
changed the title
Checkbox and Radio TooltipWrapper support for Checkbox and Radio
| @@ -220,13 +220,14 @@ function Checkbox(props: CheckboxProps, ref: ForwardedRef<HTMLLabelElement>) { | |||
| isRequired: props.isRequired || false | |||
| } | |||
| }); | |||
| let {focusableProps} = useFocusable(props, ref); | |||
There was a problem hiding this comment.
I think this is giong to double up focus events, they should already supported on Checkbox through useCheckbox->useToggle?
| @@ -186,7 +186,7 @@ function Radio(props: RadioProps, ref: ForwardedRef<HTMLLabelElement>) { | |||
| }, state, inputRef); | |||
| let {isFocused, isFocusVisible, focusProps} = useFocusRing(); | |||
| let interactionDisabled = isDisabled || state.isReadOnly; | |||
|
|
|||
| let {focusableProps} = useFocusable(props, ref); | |||
There was a problem hiding this comment.
it looks like this should already be supported as well through useRadio?
devongovett
force-pushed
the
main
branch
2 times, most recently
from
8cb1a5d
to
3013156
Compare
devongovett
force-pushed
the
main
branch
2 times, most recently
from
a79adcf
to
3013156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes part of #6142
TooltipTriggerfrom rac didn't work withRadioandCheckboxrac because they didn't haveuseFocusableinside.This PR fixes that
PS shutout to the @formaceft93 for the solution
✅ Pull Request Checklist:
📝 Test Instructions: