Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Devanagari & Bengali decimal numbering systems #6715

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Rocss
Copy link
Collaborator

@Rocss Rocss commented Jul 16, 2024

Closes #6623

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Adobe Express

@rspbot
Copy link

rspbot commented Jul 16, 2024

@Rocss
Copy link
Collaborator Author

Rocss commented Jul 16, 2024

Currently this is being tested by Express g18n team. Will come back with updating all the necessary documentation when it is validated.

@rspbot
Copy link

rspbot commented Oct 29, 2024

@Rocss Rocss marked this pull request as ready for review October 30, 2024 10:09
@Rocss
Copy link
Collaborator Author

Rocss commented Oct 30, 2024

I am marking this as ready for review as it was finally tested by Express g18n team and confirmed that number field works well for Hindi and Bengali keyboards.
Happy to address any other code review, I don't know what I missed 😅

@majornista I think this PR is affecting your PR: #6520, would you like me to add additional checks to mine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants