-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making versioning consistent and making Tree package public for release #6300
Conversation
Build successful! 🎉 |
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@react-spectrum/test-utils", | |||
"version": "3.0.0-alpha.1", | |||
"version": "1.0.0-alpha.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't this be more confusing? with all the @react-spectrum/@react-aria scopes being 3.*?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, a bit torn on this (and there wasn't a earlier conversation, just something I noticed when auditing haha). I kinda wanted to reset and follow the 1.* version pattern since the 3.* didn't really make sense since it implies that there was a 1./2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably missed a conversation about this
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'any' } |
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP