Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react canary tests #6115

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Fix react canary tests #6115

merged 4 commits into from
Mar 28, 2024

Conversation

snowystinger
Copy link
Member

Closes

For the moment, we have a few too many things to fix. So because it's a deprecation warning, I'm just silencing it for now.

Things we'll need to do at some point.
Clean up remaining import {render as ReactDOMRender} from 'react-dom';
Dynamically swap out which act we use depending on if it's in the react module.

Upgrade user event and rtl once they have support?

errors are now handled differently facebook/react#28627 we may need more error boundaries in tests, for now I've remove the check for console.error on the one which failed. I tested in the browser and it still logs the error. I've left the manual story in for the moment.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

)}
</div>
);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this story testing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see description

errors are now handled differently facebook/react#28627 we may need more error boundaries in tests, for now I've remove the check for console.error on the one which failed. I tested in the browser and it still logs the error. I've left the manual story in for the moment.

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock PR builds and main

@devongovett
Copy link
Member

I think OverlayProvider is pretty much unused at this point now that we moved to ariaHideOutside so I'm not too worried about that.

@devongovett devongovett merged commit 9d6f024 into main Mar 28, 2024
27 checks passed
@devongovett devongovett deleted the fix-tests branch March 28, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants