-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change useMenuTrigger onPressStart to state.open #6024
Change useMenuTrigger onPressStart to state.open #6024
Conversation
@LFDanLu thanks for the advice and recommendation! My CLA is signed, FYI. |
@subvertallchris Thanks for the speedy turnaround! I'll see if I can figure out a way to test this flow when I get some spare time |
Happy to help! Do you think more tests are necessary prior to merge or is this mergeable as is now? |
I'd prefer having a test that mimics the user flow of |
GET_BUILD |
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
GET_BUILD |
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'any' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Closes #5988
✅ Pull Request Checklist:
📝 Test Instructions:
MenuTrigger
I tried to write a new test covering the original condition and failed. I don't have the fluency in react-aria to know how to simulate the behavior. A test did cover the basic behavior, though, and it was updated to reflect the use of
open
instead oftoggle
.