-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#4208): Form includes label prop inherited from SpectrumLabelableProps that goes unused #4209
fix(#4208): Form includes label prop inherited from SpectrumLabelableProps that goes unused #4209
Conversation
…Props that goes unused
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it removed in the docs table
I noticed that the labelPosition prop description and a few of the others don't make a lot of sense as they don't mention that it affects every field in a form. Something for us to address later. Thanks for the fix
Props that propagate to children are further documented below: https://reactspectrum.blob.core.windows.net/reactspectrum/ac82aa5dfd1e59654194ae56d00260b08e78d84f/docs/react-spectrum/Form.html#label-position-and-alignment. The props table is a bit vague on this behavior, because the descriptions are inherited from SpectrumLabelableProps. |
Yes, I wasn't commenting on your work. We could override those descriptions and we should, but not in this PR. That was all. |
…-spectrumlabelableprops-that-goes-unused
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
Closes #4208
✅ Pull Request Checklist:
📝 Test Instructions:
Verify that
label
is not listed as a prop in Form documentation: https://reactspectrum.blob.core.windows.net/reactspectrum/ac82aa5dfd1e59654194ae56d00260b08e78d84f/docs/react-spectrum/Form.html#props🧢 Your Project:
Adobe/Accessibility