Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test transformer docs for API output #3833

Merged
merged 20 commits into from
Jan 25, 2023
Merged

Test transformer docs for API output #3833

merged 20 commits into from
Jan 25, 2023

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Dec 12, 2022

Closes

I was worried I was making changes that would break our docs/build. So I'm writing tests so that I can make the changes I want without worrying as much. It also makes it easier to try out a single case without running the entire build.

There is no need to review the snapshots in this PR, they are purely a baseline, as this PR contains no changes to the files that would affect the output of the tests.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Jan 17, 2023

@rspbot
Copy link

rspbot commented Jan 23, 2023

@rspbot
Copy link

rspbot commented Jan 24, 2023

@rspbot
Copy link

rspbot commented Jan 24, 2023

@rspbot
Copy link

rspbot commented Jan 24, 2023

@rspbot
Copy link

rspbot commented Jan 24, 2023

@rspbot
Copy link

rspbot commented Jan 24, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snowystinger snowystinger merged commit 9ddb74b into main Jan 25, 2023
@snowystinger snowystinger deleted the test-transformer-docs branch January 25, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants