Add DialogContainer component to support controlled dialogs #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
devongovett
commented
Sep 22, 2020
| @@ -37,7 +37,7 @@ const Context = React.createContext<ModalContext | null>(null); | |||
| export function ModalProvider(props: ModalProviderProps) { | |||
| let {children} = props; | |||
| let parent = useContext(Context); | |||
| let [modalCount, setModalCount] = useState(parent ? parent.modalCount : 0); | |||
| let [modalCount, setModalCount] = useState(0); | |||
There was a problem hiding this comment.
This fixes the issue with aria-hidden on an open dialog that came up before. I believe this logic was simply incorrect: each ModalProvider keeps track of the number of modals open in its subtree, but this seems to store a count of all open modals. 🤷
| @@ -35,7 +36,16 @@ describe('DialogTrigger', function () { | |||
| }); | |||
|
|
|||
| afterEach(() => { | |||
| jest.runAllTimers(); | |||
| // Ensure we close any dialogs before unmounting to avoid warning. | |||
| let dialog = document.querySelector('[role="dialog"]'); | |||
There was a problem hiding this comment.
could probably use screen.getByRole('dialog') instead
There was a problem hiding this comment.
what is screen? Any benefits or about the same?
dannify
approved these changes
Sep 29, 2020
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #966. Closes #1039.
Based on learnings from #965, this implements a
DialogContainercomponent that can be used in cases where there is no trigger element, or when the trigger may unmount while the dialog is open (e.g. a menu item). AuseDialogContainerhook is also added to allow custom dialog components to dismiss the dialog programmatically without manually passing through anonDismissfunction.In addition, this adds a warning when a
DialogTriggerdetects that it is unmounted while a modal is open, suggesting the use ofDialogContainerinstead.See the docs and updates to the Table CRUD example for details on the API.