Upgrade support for react 17 #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
changed the title
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Do we want to keep both the 16 and 17 build of storybook? and do we have a different way we want to expose the version to storybook ui? |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
Pin a bunch of versions to get some tests passing in react 17 upgrade react/react-dom deps to 17
talked to devon about focus scope tests, we're not sure why these changes don't break them changed some bubbles to capture phase added a story for testing in browser, delete it later
fix remaining failing tests now we just have weird node error messages and two hanging tests
…nested modals this should check to make sure that the outer one doesn't try to focus inside itself while the inner one is still open fix lint
…for testing 17 in next commit
…fail to build build react 17 storybook
…dress in a followup. Something about runAfterTransitions recent change is what extended the time by so much
fix a ref to the new way of doing things talked to devon about focus scope tests, we're not sure why these changes don't break them changed some bubbles to capture phase added a story for testing in browser, delete it later Queue up useId updates to fix bad setState fix remaining failing tests now we just have weird node error messages and two hanging tests Fixes the remainder of the tests, however, i need to add one now for nested modals this should check to make sure that the outer one doesn't try to focus inside itself while the inner one is still open Fix up useId so that it runs immediately if it's not in a render cycle can not put NODE_ENV before the yarn add command, it causes icons to fail to build build react 17 storybook
snowystinger
force-pushed
the
pass-react-17-in-jest
branch
from
0c9967b to
2e1d920
Compare
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
devongovett
approved these changes
Sep 29, 2020
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1074
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: