Combobox does not close on ModalOverlay click when menuTrigger=focus

[piyushsarkar]

Provide a general summary of the issue here

When combobox menuTrigger is set to focus, clicking the ModalOverlay does not close an open combobox.

<ComboBox menuTrigger="focus">
  <ComboBoxItem>Item 1</ComboBoxItem>
  <ComboBoxItem>Item 2</ComboBoxItem>
</ComboBox>

This was working correctly in react-aria-components version 1.16.0, but after upgrading to 1.17.0, clicking the modal overlay no longer closes the combobox popover.

The issue seems specific to menuTrigger="focus" since menuTrigger="input" and menuTrigger="manual" still working correctly.

🤔 Expected Behavior?

The combobox popover should close when the modal overlay is clicked.

😯 Current Behavior

The combobox popover remains open after clicking the modal overlay.

💁 Possible Solution

No response

🔦 Context

No response

🖥️ Steps to Reproduce

https://stackblitz.com/edit/c3rm1h73-dyetugob?file=src%2FExample.tsx

Version

react-aria-components@1.17.0

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

macos 26.4.1

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

[snowystinger]

Thanks for the issue. It probably broke here https://github.com/adobe/react-spectrum/pull/9768/changes#diff-6824254daab8a81b5b0cdb3845a06623eda41b64667b29f6abee7ef51da9c2af

We could try adding back some of the change from https://github.com/adobe/react-spectrum/pull/9646/changes#top though I'm not sure it'll help. The issue I suspect is that focus leave the input, but is then returned, which triggers the combobox to open again. I suspect this because if I start to enter a value in to the input, when I click on the underlay of the dialog, then the input clears and the list is unfiltered again.

Maybe we can check if focus is programmatic? though that may interfere with autoFocus. Or maybe we can check if the element we lost focus to is the one we're now receiving it from, though that could just be that there are only two focusable elements in the dialog to start with.

We'll need to keep thinking, we unfortunately need the change that lead to this.