Skip to content

fix(deps): unpin dependencies#2

Merged
tripodsan merged 1 commit intomainfrom
unpin-dependencies
Feb 6, 2026
Merged

fix(deps): unpin dependencies#2
tripodsan merged 1 commit intomainfrom
unpin-dependencies

Conversation

@dominique-pfister
Copy link
Contributor

@dominique-pfister dominique-pfister commented Feb 6, 2026

As this is a library it should not pin dependencies, or projects relying on this library that depend on some common other library (e.g. @adobe/helix-mediahandler) will have 2 versions of that library installed:

$ npm ls @adobe/helix-mediahandler
@adobe/helix-api-service@1.31.3 ./helix/api-service
├─┬ @adobe/helix-html2md@1.1.0
│ └── @adobe/helix-mediahandler@2.9.5
└── @adobe/helix-mediahandler@2.10.1

I suggest to follow the convention used in helix-shared-storage

@dominique-pfister
Copy link
Contributor Author

This is currently blocking this renovatebot PR: adobe/helix-api-service#127

Reason is: the SizeTooLargeException thrown by one version of the library will not match the instanceof expression because it's from another library version.

@tripodsan tripodsan merged commit b19b464 into main Feb 6, 2026
5 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 6, 2026
## [1.1.1](v1.1.0...v1.1.1) (2026-02-06)

### Bug Fixes

* **deps:** unpin dependencies ([#2](#2)) ([b19b464](b19b464))
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants