Does `uniq` preserve order?

[trieloff]

It would be worth noting if uniq preserves the order of elements in the sequence or not. Preserving order would be better, but might be unattainable with the Set based implementation.

[koraa]

Depends on the definition of order preserving. For an imagined example new Set([1,2,1]), what would you expect the order to be? Both [1,2] and [2,1] could be considered order preserving.

The Set documentation states:

You can iterate through the elements of a set in insertion order.

This effectively guarantees that the order would be [1,2]. Does that fit your use case?

[koraa]

If it fits your use case, would you mind adding that to the documentation and providing tests so this is marked as an official feature?

[trieloff]

[1, 2] is what I'd expect.

[adobe-bot]

🎉 This issue has been resolved in version 1.8.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀