Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@taggon
Copy link
Contributor

@taggon taggon commented Nov 7, 2014

Update Korean language.

Add and modify Korean language.
@taggon taggon changed the title Add and modify Korean language. Update Korean language. Nov 7, 2014
@ingorichter
Copy link
Contributor

@taggon Thank you very much for your contribution. In order to merge your changes, you need to sign the CLA http://dev.brackets.io/brackets-contributor-license-agreement.html. Thanks.

@ingorichter ingorichter self-assigned this Nov 20, 2014
@taggon
Copy link
Contributor Author

taggon commented Nov 20, 2014

@ingorichter I already signed the CLA when I saw the error message.
But Travis CI still fails merging my patch. What else am I supposed to do to fix it?

@ingorichter
Copy link
Contributor

@taggon It's all good now. I've triggered the build again and now it passes successfully. Thanks.

@ingorichter
Copy link
Contributor

I did a check with google translate and it looks all plausible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the SHA of the src/nls/root/strings.json that you have used as basis for the translation to the bottom of this file. Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taggon would you mind adding the SHA back to the file? Thanks.

@taggon
Copy link
Contributor Author

taggon commented Dec 2, 2014

I've created new Pull Request to add the SHA back.
This issue will be closed. Please use #10053 instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants