This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Auto-install extensions #9573
Merged
Auto-install extensions #9573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@dangoor This is ready to merge for testing. I'm still looking at how we can add some unit tests. |
| @@ -97,6 +105,8 @@ define(function (require, exports, module) { | |||
| var _idsToRemove = [], | |||
| _idsToUpdate = []; | |||
|
|
|||
| PreferencesManager.definePreference(FOLDER_AUTOINSTALL, "object", undefined); | |||
There was a problem hiding this comment.
Sorry, I missed this line on my last review. This isn't a preference, so it should not be defined on the PreferencesManager. It should either be PreferencesManager.stateManager.definePreference or not here at all.
|
@ingorichter Are you testing on the branch? I'd be fine merging this now because the one comment I had above doesn't impact the behavior here. It's just something we should clean up. |
|
Merging |
|
I'm done with testing. I found one issue that is reported here #9576 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed version of #9490
Automatically install extensions "bundled" with installer on startup. This feature relies on the installer putting zip files for "bundled" extensions into the
[install-dir]/auto-install-extensions/folder.This is for #9233
Testing Matrix for
auto-install-extensionsfolderShould fail silently
Should install extension