Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@dangoor
Copy link
Contributor

@dangoor dangoor commented Sep 30, 2014

Fix for #9327

(Note that this includes #9355 and should land after that one).

@JeffryBooher
Copy link
Contributor

@dangoor looks this pr needs another merge with master. Also, can you squash the commits?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove dead code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something that ideally should be tested, but we need to bring in some additional technology to do so... I'm not sure that would be obvious without this comment...

@JeffryBooher
Copy link
Contributor

Finished with Review. Tested on Windows and it is fixed. Just one minor nit but need to squash the commits and merge with the latest master

@JeffryBooher
Copy link
Contributor

edit added need to merge with master

@dangoor
Copy link
Contributor Author

dangoor commented Sep 30, 2014

@JeffryBooher As I was hoping, merging with master automatically removed the redundant commits from this history for this one.

@JeffryBooher
Copy link
Contributor

Change looks good. merging

JeffryBooher added a commit that referenced this pull request Oct 1, 2014
Fixes endless horizontal scrolling in the file tree
@JeffryBooher JeffryBooher merged commit 48ae54f into master Oct 1, 2014
@marcelgerber marcelgerber deleted the dangoor/9327-endless-scroll branch May 23, 2016 08:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants