Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Change CodeInspection Public API to expose providers #9189

Merged
merged 6 commits into from
Dec 3, 2014
Merged

Change CodeInspection Public API to expose providers #9189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c3e576a
Change CodeInspection public API to expose providers.
Mark-Simulacrum Sep 21, 2014
36e9908
Remove getProviders() - should never be used.
Mark-Simulacrum Oct 2, 2014
5ffdc97
Delete unregister function, add unit test for getProvidersForPath.
Mark-Simulacrum Oct 3, 2014
6628259
Change getProvidersForPath to return an empty array when no providers…
Mark-Simulacrum Oct 3, 2014
de3444f
Fix indentation of line.
Mark-Simulacrum Oct 5, 2014
12fdf81
Clone the providers array returned for a given path to prevent outsid…
Mark-Simulacrum Dec 3, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/language/CodeInspection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ define(function (require, exports, module) {
* @return ?{Array.<{name:string, scanFileAsync:?function(string, string):!{$.Promise}, scanFile:?function(string, string):?{errors:!Array, aborted:boolean}}>} provider
*/
function getProvidersForPath(filePath) {
return _providers[LanguageManager.getLanguageForPath(filePath).getId()];
return _providers[LanguageManager.getLanguageForPath(filePath).getId()].slice(0) || [];
}

/**
Expand Down Expand Up @@ -643,9 +643,10 @@ define(function (require, exports, module) {
exports._PREF_ASYNC_TIMEOUT = PREF_ASYNC_TIMEOUT;

// Public API
exports.register = register;
exports.Type = Type;
exports.toggleEnabled = toggleEnabled;
exports.inspectFile = inspectFile;
exports.requestRun = run;
exports.register = register;
exports.Type = Type;
exports.toggleEnabled = toggleEnabled;
exports.inspectFile = inspectFile;
exports.requestRun = run;
exports.getProvidersForPath = getProvidersForPath;
});
17 changes: 17 additions & 0 deletions test/spec/CodeInspection-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,23 @@ define(function (require, exports, module) {
});
});

it("should get the correct linter given a file path", function () {
var codeInspector1 = createCodeInspector("text linter 1", successfulLintResult());
var codeInspector2 = createCodeInspector("text linter 2", successfulLintResult());

CodeInspection.register("javascript", codeInspector1);
CodeInspection.register("javascript", codeInspector2);

var providers = CodeInspection.getProvidersForPath("test.js");
expect(providers.length).toBe(2);
expect(providers[0]).toBe(codeInspector1);
expect(providers[1]).toBe(codeInspector2);
});

it("should return an empty array if no providers are registered", function () {
expect(CodeInspection.getProvidersForPath("test.js").length).toBe(0);
});

it("should run two linters", function () {
var codeInspector1 = createCodeInspector("text linter 1", successfulLintResult());
var codeInspector2 = createCodeInspector("text linter 2", successfulLintResult());
Expand Down