Show LESS errors in console #8736
Conversation
| try { | ||
| result.resolve(tree.toCSS()); | ||
| } catch (toCSSError) { | ||
| console.error(toCSSError.filename + ":" + toCSSError.line + " " + toCSSError.message); |
There was a problem hiding this comment.
@jasonsanjose On master, I assume the uncaught exception falls through to the top of the stack, causing dev tools to log a stack trace plus the value of toCSSError.toString(). Does the toString() not include this info already? Or were you not even seeing the exception getting logged at all for some reason?
There was a problem hiding this comment.
Right, uncaught exception without a useful toString():
|
@jasonsanjose What types of LESS errors should I expect to see? I tried inserting an undefined var at the beginning of brackets.less which break Brackets styles, but I don't see any error in chrome console. I'm also not seeing info messages that I'm seeing in master such as: |
|
@redmunds try modifying LESS for an extension that loads a .less file at runtime. |
|
OK, I am getting info messages with valid syntax. Looks good. Merging. |
…o the console (not just the output stage). Also covers cases where the file doesn't exist, for both CSS & LESS.
|
@jasonsanjose I ran across a case where this still didn't emit any warnings. Posted PR #9557 to make this cover more cases. Want to review it? |
|
(One example case is an extra stray |
…o the console (not just the output stage). Also covers cases where the file doesn't exist, for both CSS & LESS.
…-file-system * upstream/master: (113 commits) Don't keep focus on mouse clicks on tabs. Refinement of PR #8736: also log LESS errors from the parsing stage to the console (not just the output stage). Also covers cases where the file doesn't exist, for both CSS & LESS. fix documentation issues fix documentation issues convert status styles/tooltips array to object remove unused modules update Copyright year to 2014 fix JSHint issue update name in transport package.json During rename in the tree, allow only default behavior. Fix bug #9966 ([CEF 2171] JSLint doesn't work) - Switch to a private fork of JSLint with the bug fix cherry-picked in so we're not stuck upgrading to a much newer JSLint which has the fix but is significantly stricter / less configurable. fix params passed to internal funcs Ensure that the baseDir for createNewItem is within the project. Further improvde readability by grouping the first part of the expression together. Improve readability of fix. Fixes the exception thrown when the provider list for a given language is empty/undefined. remove errant whitespace from previous commit add methods to align it with LiveDevelopment API remove array from event arguments Clone the providers array returned for a given path to prevent outside modification. ... Conflicts: src/LiveDevelopment/main.js src/document/DocumentCommandHandlers.js
For @larz0 to help debug LESS errors, e.g.