This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Update getting started (en-us) #8606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of the URL's at the bottom have been updated or moved, for example GitHub and Twitter are https by default now.
Contributor
|
Looks good.
Sure. http://brackets.io uses |
Contributor
|
Thanks. Merging. |
redmunds
added a commit
that referenced
this pull request
Aug 4, 2014
Update getting started (en-us)
Member
|
Hmm, we really should have updated all the other languages to match. @wormeyman Do you want to submit a PR that updates the same URLs in all the other locales of the Getting Started project? (Afaik none of these links vary by locale) |
Contributor
Author
|
Sure @peterflynn I'll Look into it. |
Member
|
Thanks! |
Contributor
Author
|
I did my commits on the release branch should i pull against that or the master branch? @peterflynn edit: https://github.com/wormeyman/brackets/tree/Get-Involved-url-Update |
Member
|
@wormeyman The release branch is basically closed at this point, so please target at master now. Thanks for the fast response! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some of the URL's had changed in the get involved section such as GitHub and Twitter moving to https by default and google added a Hash Bang (#!) while twitter removed theirs.
Also would we want to link to the freenode webchat?