This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Remember files that timed out in Tern #8269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
@dangoor Remaining issue is discussed in this comment thread. |
| // The defaultExclusions are the ones we ship with Brackets to filter out files that we know | ||
| // to be troublesome with current versions of Tern. They can be overridden with a .brackets.json | ||
| // file in your project. defaultExclusions is an array of globs. | ||
| var defaultExclusions = PreferencesManager.get("jscodehints.defaultExclusions") || []; |
There was a problem hiding this comment.
I wonder if we should get rid of defaultExclusions at this point. Automatically detecting problem files seems better and more scalable.
There was a problem hiding this comment.
Do you think anyone is using it to exclude entire folders for performance? Doesn't hurt to leave it in.
|
@dangoor Ready for another review. I think it would be safer to leave defaultExclusions in place in case anyone is using it. |
|
@dangoor OK, I removed |
|
Looks good. I noticed that the string said |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a squashed version of PR #8198. See for more comments.
This is to finish Trello Card: https://trello.com/c/2ra9FzGL/1284-m-js-code-hints-automatic-crash-preventer