This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Land 'Replace In Files' in master #8169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e apparently unused bits.
…t into a new FindBar component. There are still a few places in FindInFiles where it's monkey-patching directly into the FindBar's ModalBar. Hoping to eliminate those in future.
Also fixed a bug and dealt with some nonobvious asynchrony in one of the existing tests.
…add confirmation dialog. Clean up some unnecessary runs() in tests.
Logically, this is a single operation, not a set of merged adjacent operations, and we wouldn't want a second replaceAll done immediately afterward to merge with it (though it would be difficult to get into that case).
* hitting Enter in Find field sets focus to Replace field * hitting Enter in Replace field starts the search
…ed by a Replace in Files operation
… in Replace in Files unit tests
Add Replace in... to context menus
[replace-across-files] Replace in Files
[replace-across-files] Unify Find Bars across FindReplace/FindInFiles
…n is disabled This is a port of 1bb3286 to the replace-across-files branch - the unit test moved from FindReplace-test.js to FindInFiles-test.js, so had to be double- fixed in this branch.
Fix Replace in... unit tests
…oResults() and parseQuery() cleanup
* Got rid of unnecessary partial in search-summary-paging.html * Refactored change notifications in Document to _notifyDocumentChange() method, and fix up similar logic in SpecRunnerUtils.createMockActiveDocument() * Moved makeDialogFileList from StringUtils to FileUtils * Renamed "file/item/index" to "fileIndex/itemIndex/matchIndex" for clarity in SearchResultsView * Return empty array from _getSearchMatches instead of null * Properly debounce document changes when updating search results view * Fix up file rename handling in search results view to use indexOf() instead of match() * Rename "doReplaceAll" event on FindBar to "replaceAll" * Return a promise from FindInFilesUI.searchAndShowResults() * Replace calls to _.filter() and _.map() with native JS calls * Lots of comment/JSDoc improvements
… every time Also fixes a long-standing bug in updating line numbers for existing result matches.
…Clean up duplicate code.
* Got rid of "navigator" and "scope" options to FindBar, since they're redundant with "multifile" * Renamed SearchModel.addResults() to setResults() and made it remove the existing results first if any * Comment clarifications
[replace-across-files] Code review fixes
|
Merged with master, but there appear to be some JSHint failures. One set is bonafide (in FindInFilesUI.js), but the rest are in test files, so I need to exclude those. |
|
Merging. |
njx
pushed a commit
that referenced
this pull request
Jun 19, 2014
Land 'Replace In Files' in master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the one PR that brings all the others together... and in the darkness binds them?