Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@redmunds
Copy link
Contributor

I noticed this when looking at the JS Code Hints code. If there are no files returned from preferences.getExcludedFiles(), then the jscodehints.defaultExclusions will not get checked.

@dangoor We should get this in for Release 0.41

@dangoor dangoor self-assigned this Jun 18, 2014
@dangoor
Copy link
Contributor

dangoor commented Jun 18, 2014

I was puzzled by how the defaultExclusions were even working, but it turns out that the bug here is that the defaultExclusions are turned off only if you have a code hints preferences file that expressly has no excluded files, which is likely not too common. That said, the defaultExclusions should always apply, so this is a good catch!

dangoor added a commit that referenced this pull request Jun 18, 2014
Fix error when checking for exclusions
@dangoor dangoor merged commit 0149fa9 into master Jun 18, 2014
@dangoor dangoor deleted the randy/fix-exclusion-bug branch June 18, 2014 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants