This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix live highlight when starting from a CSSDocument #8157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SAplayer This looks like a pretty clean solution. Can you add a unit test for this case? |
| var liveDoc = _createDocument(doc); | ||
| // The doc may already have an editor (e.g. starting live preview from an css file), | ||
| // so pass the editor if any | ||
| var liveDoc = _createDocument(doc, doc._masterEditor || undefined); |
There was a problem hiding this comment.
No need to use doc._masterEditor || undefined. This can simply be doc._masterEditor.
|
@redmunds I tried to write tests for that particular functionality, but unfortunately I weren't able to. |
|
@SAplayer There doesn't appear to be any mechanism for verifying highlighting, so that's OK. Triage complete. |
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Jun 26, 2014
Fix live highlight when starting from a CSSDocument
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7453.
I wonder whether there's a nicer solution.