Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@h1w4y
Copy link
Contributor

@h1w4y h1w4y commented May 28, 2014

addresses issue #7716
when running from source, the about screen will show "Build Timestamp: Running from local source."
when running from dist, the about screen will show "Build Timestamp: Wed, 28 May 2014 04:33:48 GMT"

updated build-config grunt task to add a timestamp to the dist/config.json.
added a placeholder to the config.json files that are maintained in src.

I took a guess that updating a src file every build script run would cause too many changes for source control. Hopefully I'm on the right track here. I'm not sure exactly how dist/ is packaged and deployed, so my testing was done by moving the dist/config.json into src/config.json and running brackets.

@redmunds redmunds self-assigned this May 28, 2014
src/config.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HighwayChile Any reason that you removed newline from end of file? If not, then restore it to remove this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@redmunds that's my mistake, pushed an update. Thanks

@redmunds
Copy link
Contributor

@njx @larz0 With this change, the About dialog looks like this:

about-build-date

Question 1: Is a new paragraph for build timestamp ok, should it just be appended to first paragraph, or somewhere else?

Question 2: Is GMT ok, or should it be local time?

@larz0
Copy link
Member

larz0 commented May 30, 2014

@redmunds could we try removing the bottom margin of "sprint 40…"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably shouldn't hardcode this (i18n).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larz0 Here's a view without the margin under sprint 40...

capture

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and another view with uniform letter casing

capture

And what it would look like running from dist/ (with timestamp)
capture

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SAplayer regarding the hardcoding and (i18n) -- I'll look for a better way to inject that text if the code is running from src/

Does using that text seem right when running from src/ ?
The other option would be to store the build timestamp someplace outside of source control. Then the 'about' view could always have a build date.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the latter one is probably better as "Hackers" are advised to only create a dev symlink, so most of them (including me) won't ever run the build script and therefore the build date stays the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can get Brackets.exe file date when opening About dialog, then no need to even store it in a json file, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@redmunds But that won't work with InBrowserShell and so on.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that won't work with InBrowserShell

Good point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I will work on option 3 later today. As @peterflynn suggested, if dev build is true, I'll hide the whole line.

Does the last screenshot above look good?

What about timezone?

  1. UTC (shown as GMT)
  2. build server timezone
  3. client timezone

I like UTC or client tz.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the last screenshot above look good?

Yes, that looks good.

What about timezone?

The dev team may need this info to help determine what code is being run, so it should not be converted to user timezone to avoid confusion. I, personally, prefer build server timezone (which shows GMT offset), but GMT should be OK (since this will probably be mostly used for date, not time).

@h1w4y
Copy link
Contributor Author

h1w4y commented Jun 3, 2014

looks like this when running from /dist

timestamp_running_in_dist

@h1w4y
Copy link
Contributor Author

h1w4y commented Jun 3, 2014

please hold, looks like i broke something

@h1w4y
Copy link
Contributor Author

h1w4y commented Jun 4, 2014

closing this. I'll submit another, cleaned up pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants