Update strings.js #7462
Update strings.js #7462
Conversation
JeffryBooher
commented
Apr 9, 2014
JeffryBooher
commented
- branch of Update strings.js (italian) #7425
Add /*Last translate "SHA1"*/. I have corrected some errors, with suggestions of other people.
|
There are a couple of questions in the original pull request but we don't need to wait for @Denisov21 to respond before merging into Release. |
There was a problem hiding this comment.
@JeffryBooher This is not the correct SHA and need to be replaced with the correct one.
There was a problem hiding this comment.
@RaymondLim The version that's in the release branch doesn't have a SHA. Can we just remove it?
There was a problem hiding this comment.
@JeffryBooher That's why I was thinking of guiding @Denisov21 to do translation using the latest English version and put the SHA of the latest. Besides, there was one pull request for Italian translation that got merged a few days ago and it may be conflicting with this pull request.
There was a problem hiding this comment.
@RaymondLim I reviewed the changes from @Denisov21 and found only 1 conflict which Google Translate preferred the existing string over the one in this pull request.
There were a few others that Google Translate had indicated may not be a proper translation as well so we might hold off on this pull request until after we get feedback from a third source.
There was a problem hiding this comment.
the comments I had are in the original pull request, BTW: #7425
There was a problem hiding this comment.
It is wrong and @Denisov21 still can't figure out the right one yet.
|
Closing for now in lieu of 6496559 |
