Various small cleanups - largely docs #7264
Conversation
peterflynn
commented
Mar 20, 2014
peterflynn
commented
- Fix & update documentation in a bunch of places
- Add a fail-fast warning when missing DOM id will cause bottom panels to not get created correctly (per Resizer module should provide better information for error condition #6252)
- Add extra FileSystem unit tests around the fs root
- Fix bits of the ProjectManager exclusion regex that were missing trailing "$" (I verified these are all full names, not just prefixes) -- and add WebStorm project state as an excluded item
- Slightly better messages when unit tests fail due to a Promise resolution going the wrong way
- Fix some minor JSLint errors
- Add a fail-fast warning when missing DOM id will cause bottom panels to not get created correctly (per #6252) - Add extra FileSystem unit tests around the fs root - Fix bits of the ProjectManager exclusion regex that were missing trailing "$" (I verified these are all full names, not just prefixes), and add WebStorm project state as an excluded item - Slightly better messages when unit tests fail due to a Promise resolution going the wrong way - Fix some minor JSLint errors
| @@ -186,7 +186,7 @@ define(function (require, exports, module) { | |||
| * Creates a new panel beneath the editor area and above the status bar footer. Panel is initially invisible. | |||
| * | |||
| * @param {!string} id Unique id for this panel. Use package-style naming, e.g. "myextension.feature.panelname" | |||
There was a problem hiding this comment.
Is this still required? We don't use it anymore in the function and I guess it's only there to not break anything. Perhaps we should issue a deprecation warning then.
There was a problem hiding this comment.
I think it was actually added as a forward-looking thing (we might have getters keyed on this id in the future, like LanguageManager.getLanguage()) -- it's not something we used to use and then removed at some point.
|
@peterflynn Done with review. |
|
@ingorichter I pushed some docs clarifications around PanelManager's & Resizer's use of ids. Lmk if that does the job! |
|
@peterflynn That looks better to me. There is one typo and we are ready to merge. Thanks. |
|
@ingorichter Oops, good catch. Fixed now. |
|
Thanks @peterflynn. Merged! |
Various small cleanups - largely docs
