This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Do not close/reopen live preview on currentDocumentChange #7119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avigate() instead and update agent and server state as needed.
Member
Author
Merged
Contributor
|
Holy crap! It changes docs so fast I thought something was broken :) Awesome! |
Member
Author
|
RIGHT?! |
Contributor
There was a problem hiding this comment.
JSLint error: _reset was used before it was defined
Contributor
There was a problem hiding this comment.
_createDocument() can return null. It looks like _server.add() does not handle null. Should this get handled by caller or server?
Contributor
|
Done with review. |
Member
Author
|
@redmunds ready |
src/extensions/psd-lens
Outdated
Contributor
There was a problem hiding this comment.
I don't think you meant to commit this change.
Member
Author
There was a problem hiding this comment.
WHEW! Thanks. Removed.
Contributor
|
Merging. |
redmunds
added a commit
that referenced
this pull request
Mar 7, 2014
Do not close/reopen live preview on currentDocumentChange
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges to
randy/live-dev-fixesfor #6889. This is not formaster.Page.navigate()instead and update agent and server state as needed.frameNavigated