Made "Show in OS" OS-specific

[marcelgerber]

This is for #6970, it makes CMD_SHOW_IN_OS OS-specific (Finder on Mac, Explorer on Win).
@couzteau for the german strings

[TomMalbran]

Instead of having an if for the register command, I think it would look better to do something like

var showInOS = Strings.CMD_SHOW_IN_OS;
if (brackets.platform === "win") {
    showInOS = Strings.CMD_SHOW_IN_EXPLORER;
} else if (brackets.platform === "mac") {
    showInOS = Strings.CMD_SHOW_IN_FINDER;
}

Before the we register all the commands and then just call CommandManager.register(showInOS, Commands.NAVIGATE_SHOW_IN_OS, handleShowInOS);.

The same thing could be applied to the exit command.

An alternative could be to set a string in Strings.js, but not sure about that.

[marcelgerber]

I thought about that, too, but then I saw how it is done above (exit command).
But yes, this sounds reasonable. Will change it tomorrow.

[TomMalbran]

Sure. We could use the same if to set the quit strings too.

[TomMalbran]

BTW, it might be easier to not include the translations in the PR. If you do we need someone else to review them.

[ingorichter]

@SAplayer @TomMalbran IMO, the strings look good.

[marcelgerber]

Just pushed a commit.
This has some whitespace changes in it, so I recommend you to review using https://github.com/adobe/brackets/pull/6982/files?w=1
I can remove these changes if you want me to.

[TomMalbran]

Could you place both if at lines 1552, so that we can then have all the commands together? You can also use the same if (brackets.platform === "win") for both showInOS and quitString.

[marcelgerber]

I think the register commands are curently sorted by command type (file, navigate, edit, ...), so this could cause ambiguity.
I'll wait for another opinion.

[TomMalbran]

I don't understand... I am saying about moving just the Strings declarations, not the CommandManager.register.

[marcelgerber]

Ah yes, must have understood you wrong.
Just pushed another commit.

[TomMalbran]

My point was to have it like this:

var quitString  = Strings.CMD_QUIT,
    showInOS    = Strings.CMD_SHOW_IN_OS;
if (brackets.platform === "win") {
...(the rest of the if, else if code)
}

// Register global commands
CommandManager.register(Strings.CMD_FILE_OPEN,          Commands.FILE_OPEN, handleFileOpen);
...(all the other commands)
CommandManager.register(showInOS,                       Commands.NAVIGATE_SHOW_IN_OS, handleShowInOS);

So that there is nothing in between the CommandManager.register and would make it easier to read.

[ingorichter]

This looks good. Thank you both.

[JeffryBooher]

Thank you @SAplayer -- this has annoyed me since the dawn of time!