This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix for #5923: Maintain scroll position for each ExtensionManager tab #6637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| $(this).tab("show"); | ||
|
|
||
| $(".modal-body", $dlg).scrollTop(models[_activeTabIndex].scrollPos || 0); |
There was a problem hiding this comment.
Just one nit. Probably don't need the newline characters, just keeping with the existing coding style. Otherwise, it looks good. Nice, simple change.
Probably don't need unit tests. Small, localized change. If it fails, nothing will break.
|
@SAplayer, initial review complete, just one little nit, otherwise it looks good. |
|
@lkcampbell Just fixed this nit. |
|
Looks good. Merging. |
lkcampbell
added a commit
that referenced
this pull request
Jan 26, 2014
Fix for #5923: Maintain scroll position for each ExtensionManager tab
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5923 @lkcampbell @couzteau
This fixes #5923 where the scroll position of the ExtensionManager tabs was not maintained.
Is this a good approach? Should I (try to) add an unit test?