-
Notifications
You must be signed in to change notification settings - Fork 7.5k
German Translation #6416
German Translation #6416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never seen the context - should this be "Speichern unter" or "Speicher als"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would call it "Speichern als...".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, that's better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said, I've never seen the context - In case it means "Save file in selected dir", I would take Speichern unter... (as this is very common). But if it wants to say "Save the file with another extension", then I'd take Speichern als...
German:
Ich habe noch nie wirklich den Kontext gesehen - Wenn es heißen soll "Speichern in ausgewähltem Ordner (mit Dialog zum Auswählen des Speicherorts)", dann würde ich Speichern unter... lassen (da es sehr geläufig ist).
Wenn es aber sagen soll "Datei als anderer Dateityp speichern", dann würde ich auch Speichern als... nehmen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I just saw this comment, I'd leave it as it is "Speichern unter"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SAplayer the usual file save dialog will be opened and the user has the ability to provide and new name and new location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this is not yet merged. But it'll in #6411
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged in now.
|
Just pushed a new one so that everything is up to date. |
src/nls/de/strings.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ersetzen statt Überschreiben?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If both of you (@couzteau and @ingorichter) agree with that, I'd change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SAplayer I think Ersetzen is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just changed that, but FYI: "Überschreiben" is used in some more cases, just try to search for that.
|
FYI: I'll update this PR in a few minutes, as I just saw (git merge) that there were some changes in nls/root. |
|
Ready for re-review. |
src/nls/de/strings.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be aligned properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my mistake. Just fixed.
Don't know why JSLint wasn't complaining about this one.
|
@SAplayer good translation. |
|
@ingorichter Just saw Strings PRs should point to the release branch. |
|
@SAplayer that would be great If you could create a new one. Sorry, but we've branched master into release today in order to finish sprint 36. Thanks. |
|
Closing in favor of #6632 |



@couzteau @ingorichter