This repository was archived by the owner on Sep 6, 2021. It is now read-only.
add 'Korean (ko)' Localization #6272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
src/nls/ko/strings.js
Outdated
Member
|
Thanks @heisice. If you know any other Korean speakers that can review this, please go ahead and tag them here. Also, please sign the contributor license agreement http://dev.brackets.io/brackets-contributor-license-agreement.html so that we can merge this pull request after review. |
Contributor
Author
|
sign contributor license agreement was done. thanks. |
copyright year modified.
Contributor
Author
|
translation updated. thank you for review, @everyevery. |
Member
|
Thanks @heisice. A few more things to do:
I can merge this PR as soon as this is done. |
replace indentation as four spaces.
add LOCALE_KO
Contributor
Author
|
ok. all done. |
Member
There was a problem hiding this comment.
Based on the content here, I believe this should have been LOCALE_KO. I'll go ahead and merge this PR and submit a new one with the fix.
jasonsanjose
added a commit
that referenced
this pull request
Jan 6, 2014
add 'Korean (ko)' Localization
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i added Korean Language Localization files. please merge, thanks.