-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[Close Others] Fix #6019: Contextual Close Others menu entries #6020
[Close Others] Fix #6019: Contextual Close Others menu entries #6020
Conversation
CommandManager.get(close_below).setEnabled(true); | ||
} | ||
|
||
if (workingSet.length === 1) { // hide "Close Others" when there is only one file in Working Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, all the commands should be disabled, since you can't close other files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They will be disabled too as the selected entry is both first and last (and only) entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. Didn't saw that before.
Btw: Is there another handler that is called when (before) opening the context menu of the Working Files? |
Assigning to @JeffryBooher |
Nominating for Sprint 35 |
[Close Others] Fix #6019: Contextual Close Others menu entries
Looks good...Merging |
I forgot about this PR, but in the meantime I found #5952. I won't say any of these is better or worse, but a difference worth mentioning is using |
This is for #6019, it makes the Close Others context menu entries contextual so that they are dynamically disabled and enabled.