Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix context menu width #5398

Closed
wants to merge 2 commits into from
Closed

Fix context menu width #5398

wants to merge 2 commits into from

Conversation

martinstarman
Copy link
Contributor

Fix for context menu when strings is longer than menu width.
context-menu
After this patch
after
Plus remove some unnecessary spaces.

@ghost ghost assigned couzteau Oct 2, 2013
@marcelgerber
Copy link
Contributor

Works for me. Would be nice to fix it.

@peterflynn
Copy link
Member

This CSS change will affect code the hint popup's width too, so we should be careful to test that as well.

@couzteau
Copy link
Member

couzteau commented Oct 3, 2013

EWF had the same problem with long font names in code hints. There we chose to use an ellipsis,
i.e. Rychlá dokumen... Should we do the same in the context menus?

@marcelgerber
Copy link
Contributor

I don't really like this idea, because maybe in some language you can't guess what it means when it is truncated.

@peterflynn
Copy link
Member

The CSS change applies to the wrong part of the HTML menu bar (.toolbar .nav is the overall menu bar, not something in the dropdowns). But I can't find anywhere in the HTML menu bar DOM structure where applying this fix does work. So it appears it won't fix ones like #5411.

@ghost ghost assigned peterflynn Oct 3, 2013
@peterflynn
Copy link
Member

@martinstarman I'm going to see if I can come up with anything more general. At first glance it seems like the float approach we're currently using should 'just work' without any width tricks needed... http://jsfiddle.net/rGwNJ/

Given that it used to work in the main menus at least, I'm guessing some unrelated CSS update (or our Bootstrap upgrade) broke stuff unexpectedly.

@martinstarman
Copy link
Contributor Author

@peterflynn probably yes, but I played with it for 3 days and I have not found another solution.

@peterflynn
Copy link
Member

@martinstarman I was able to come up with a more general solution which was landed in PR #5580, so I'm closing this for now. My fix may not work across browsers, so we may have to revisit this down the road -- I put some detailed notes in #4593 for future reference, though.

@peterflynn peterflynn closed this Oct 23, 2013
@martinstarman martinstarman deleted the context-menu branch October 24, 2013 05:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants