This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Matching brackets color tweak #5355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@couzteau NJ, Larz and I are all happy with the new color here. And code looks fine to me. You ok if I just merge this now? |
|
I also like that the important! attribute is gone. merging |
couzteau
added a commit
that referenced
this pull request
Sep 27, 2013
Matching brackets color tweak
|
Sweet! Thx. |
|
@couzteau - fyi, after merging ordinary pull requests, please go ahead and click the "delete branch" button. Thanks. |
|
@njx Ok - will do that moving forward. Wasn't sure what the common practice on the brackets team is. |
|
Pretty much the only time we'll leave a branch in the central repo is if it's part of some longer-term development effort. But for small bugfixes we just delete them right away after merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #5347.