This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Upgrade JSLint to the commit we were using before switching to a submodule #4642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@TomMalbran Thanks! I've been running with that SHA since yesterday and it seems good. Do you want to also roll back the indentation changes that were made in CSSUtils-test in #3429 though? |
Contributor
Author
|
Sure, it did looked better before. |
Contributor
Author
|
@peterflynn done. I also reverted some fixes I recently did in #4635. |
Member
|
Looks perfect! |
peterflynn
added a commit
that referenced
this pull request
Aug 2, 2013
Change JSLint back to the commit we were using before switching to a submodule
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @peterflynn mentioned in #4467 I checked to a slightly older version of JSLint with switching to a submodule. I thought it wouldn't be an issue, but there are new indentation issues that can be seen now but not with the version we used to have, like in
EditorCommandHandlers. This would also be fixed by #4557, but until then, this gives an easy fix.