Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Confirm folder delete - fixes issue #4446 #4515

Merged
merged 8 commits into from
Aug 1, 2013
Merged

Conversation

gmp
Copy link
Contributor

@gmp gmp commented Jul 19, 2013

Added confirm delete modal dialog when user deletes folder (not file) - issue #4446.

Passes lint and all tests. Have not added new tests (doesn't look like tests for file delete are in the DocumentCommandHandlers-test.js), but I'd love to add some!

Signed CLA.

Let me know if there's anything else I can do!

@@ -103,6 +103,8 @@ define({
"SAVE_CLOSE_MESSAGE" : "Do you want to save the changes you made in the document <span class='dialog-filename'>{0}</span>?",
"SAVE_CLOSE_MULTI_MESSAGE" : "Do you want to save your changes to the following files?",
"EXT_MODIFIED_TITLE" : "External Changes",
"CONFIRM_FOLDER_DELETE_TITLE" : "Confirm Delete",
"CONFIRM_FOLDER_DELETE" : "Are you sure you want to delete the folder?",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To show the file, use Are you sure you want to delete the folder <span class='dialog-filename'>{0}</span>? or similar. After using StringUtils.format, the folder name will replace {0} in the string.

@TomMalbran
Copy link
Contributor

This works great. Thanks for your work in this. I added a few comments around.

@gmp
Copy link
Contributor Author

gmp commented Jul 19, 2013

@TomMalbran Thanks for the quick feedback Tom! Made the requested changes.

Let me know if there's anything else.

Look forward to diving in deeper in the coming days!

@ghost ghost assigned TomMalbran Jul 19, 2013
@julianasuh
Copy link
Contributor

Assign to @TomMalbran

{
className : Dialogs.DIALOG_BTN_CLASS_PRIMARY,
id : Dialogs.DIALOG_BTN_OK,
text : Strings.CMD_FILE_DELETE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I prefer if this was a new string. If we ever change the name of the Command, this button should still be delete. Could you add the new string? Place it close to CANCEL and OK, as is the name of the button.

@TomMalbran
Copy link
Contributor

@g-palmer Thanks for the updates. I have one final comment. After that, we can merge, but since this adds new strings and we are past the UI is freeze. Will have to wait till the start of the next Sprint, around the 25th.

@gmp
Copy link
Contributor Author

gmp commented Jul 20, 2013

Made the change and added Strings.DELETE. I think this is what you were looking for.

Thanks again!

@TomMalbran
Copy link
Contributor

Yes. Thanks. Will have to wait for the next Sprint to merge as mentioned.

@gmp
Copy link
Contributor Author

gmp commented Jul 20, 2013

Yep. No worries. Glad it worked.

@TomMalbran
Copy link
Contributor

We are in Sprint 29, so we can merge this now :)

TomMalbran added a commit that referenced this pull request Aug 1, 2013
Confirm folder delete - fixes issue #4446
@TomMalbran TomMalbran merged commit f04c489 into adobe:master Aug 1, 2013
@gmp
Copy link
Contributor Author

gmp commented Aug 3, 2013

Woohoo!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants