This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Allow all files to be opened by drag and drop #4413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Contributor
|
Looks good to me. Merging. |
RaymondLim
added a commit
that referenced
this pull request
Jul 11, 2013
Allow all files to be opened by drag and drop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peterflynn @RaymondLim
Remove
FileUtils.isTextFile()since it was giving too many false negatives. The drag and drop code now accepts all files, and relies on FILE_OPEN to determine which files can or cannot be opened.This required adding an optional
silentparameter toFILE_OPEN. When true, errors are not shown when opening files.See this comment for more details.