This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Add Editor optionChange event #4162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did we want to call these settings "options" or "preferences"? Seems like the current implementation calls the dynamic settings to the Editor "options" and the persisted settings "preferences", so I picked "optionChange". Let me know if the event name is okay or if you want me to change it to "preferenceChange" or "prefsChange". |
This was referenced Jun 8, 2013
ghost
assigned 
|
I like the idea of calling them "options" in this case, specifically for the reason you cite. I suspect that when we build up the preferences system a bit, many of CM's options will become available as prefs in Brackets and we may end up deprecating this. But, until then, this solution seems reasonable. I'll merge this after sprint 26 is tagged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Editor optionChange event.
Triggered when an option for the editor is changed. The 2nd arg to the listener is a string containing the editor option that is changing. The 3rd arg, which can be any data type, is the new value for the editor option.