[ARCH] Updated bootstrap to 2.3.1 and less to 1.3.3 (needed for bootstrap) #3996

WebsiteDeveloper · 2013-05-26T11:10:49Z

@gruehle finally rebased correctly.
This supersedes #3672.

explicitly set margin-top to 0

I added this because somehow the relative path of the WebPlatform logo isn't found.

TuckerWhitehouse · 2013-05-26T15:31:00Z

@WebsiteDeveloper modal windows seem to be broken. If I try to open Brackets > About or File > Extension Manager, I get the backdrop, but no modal window... and then brackets goes into a sort of broken state where none of the menu commands word, and I have to force close it. No errors in the dev console.

Mac OS X 10.8.3

WebsiteDeveloper · 2013-05-26T15:39:50Z

i already saw that myself, it seems that this is related to the dialog animations.
will put up a fix.

+ one UI fix

WebsiteDeveloper · 2013-05-26T16:44:12Z

@TuckerWhitehouse pushed a fix.
I would appreciate it if you would test the branch a bit more and notify me about anything you notice.

TuckerWhitehouse · 2013-05-26T18:28:38Z

@WebsiteDeveloper looks good!
Using it to test right now and everything seems to be working without issue. I'll let you know if I find anything.

gruehle · 2013-05-28T20:19:52Z

src/extensions/default/WebPlatformDocs/InlineDocsViewer.js

@@ -41,7 +41,7 @@ define(function (require, exports, module) {
    var inlineEditorTemplate = require("text!InlineDocsViewer.html");

    // Load CSS
-    ExtensionUtils.loadStyleSheet(module, "WebPlatformDocs.less");


Why was this changed from .less to .css? ExtensionUtils.loadStyleSheet() needs to support loading css or less files.

@gruehle ExtensionUtils.loadStyleSheet() does support both css and less files (unless something broke).

its actually not a problem with the function, but with the way less is interpreting the file path of certain urls.
Those urls weren't loaded properly because they did point to an nonexistent file after being processed bei less.
This seems due to a change in Less which changes the handling of relative urls.
I tried finding another workaround but didn't find one for now.

Yeah, the url rewriting rules changed in less 1.3.2. Adding rootpath: dir to the options structure on line 88 of ExtentionUtils.js solves the problem.

Well thanks, didn't find that out will fix it when i push a bunch of fixes.

gruehle · 2013-05-28T20:50:30Z

Found another one that needs updating: alert-message should be alert. This is used in the find bar, project settings dialog, and a couple extension dialogs.

gruehle · 2013-05-28T20:56:02Z

And one more: Twipsy. Live Development shows a twipsy when the connection has been severed. Twipsy has been renamed Tooltip, so the live dev code needs to be updated, and src/widgets/bootstrap-twipsy-mod.js should be removed.

njx · 2013-05-28T21:00:08Z

@DennisKehrig made a number of modifications to Twipsy to deal with our use case. Those would need to be ported to the new version.

gruehle · 2013-05-28T21:03:05Z

src/htmlContent/extension-manager-dialog.html

@@ -7,6 +7,6 @@ <h1 class="dialog-title">{{EXTENSION_MANAGER_TITLE}}</h1>
    <div class="modal-body no-padding zebra-striped"></div>


This zebra-striped should be table-striped

dangoor · 2013-05-30T19:19:12Z

@WebsiteDeveloper Thanks for all of the work on getting LESS and Bootstrap updated!

@TuckerWhitehouse and I have been working on the jQuery 2.0 update. We really want to get all of these upgraded packages on master as early as we can to get the most testing on it that we can. To that end, I've put up a branch that has everything integrated (including this pull request):

https://github.com/adobe/brackets/tree/jQueryLESSBootstrap

Brackets doesn't boot on that branch because of Twipsy (fails on $.browser, which is gone).

@WebsiteDeveloper how are your latest fixes coming? I can help out if there's something you haven't gotten to yet, and Glenn will be back around tomorrow. Ideally, we'd merge jQueryLESSBootstrap to master tomorrow.

Thanks again! Getting all of these upgrades in this sprint will be great.

WebsiteDeveloper · 2013-05-30T19:47:44Z

@dangoor all fixes except the replacement of the twipsy plugin should be done.

WebsiteDeveloper · 2013-05-30T19:51:46Z

Is there a good way too test the appearance and the behavior of the twipsy?
So i can try to replace it with the tooltip.

gruehle · 2013-05-30T20:50:48Z

@WebsiteDeveloper - the easiest way to see the twipsy is to start live development and then show dev tools on the opened page. You will see a twipsy pointing to the live development lightning bolt.

For reference, #2178 is the pull request where twipsy was added (and modified).

WebsiteDeveloper · 2013-05-31T15:09:21Z

@dangoor i would appreciate a bit help with the tooltip, because i currently don't have the time to digg into it.

dangoor · 2013-05-31T16:34:32Z

@WebsiteDeveloper I've taken a bit of a look. Unfortunately, our changes to twipsy don't cleanly apply to the tooltip. If @gruehle doesn't get to it today, I can take a look Monday morning.

Making the tooltip work properly appears to be the big thing keeping the jQueryLESSBootstrap branch from working reasonably well (possibly well enough to merge for testing to begin)

njx · 2013-05-31T16:58:55Z

@DennisKehrig made the original twipsy mods - Dennis, would you have any time to help out with migrating it to Bootstrap 2?

DennisKehrig · 2013-05-31T17:01:40Z

@njx Not for at least another week, sadly!

njx · 2013-05-31T17:15:45Z

No prob, we'll figure it out :)

gruehle · 2013-05-31T18:06:16Z

I pushed a fix to the jQueryLESSBootstrap branch. The fix updates the bootstrap-twipsy-mod.js file to use tooltip classes instead of twipsy classes, and makes the code work with jQuery 2.0. This seems simpler than trying to wrestle with Bootstrap tooltip code.

WebsiteDeveloper · 2013-06-01T22:58:53Z

@gruehle i agree it makes a lot easiery fix.
Maybe i'll look into modifying the tooltip code in a week or so, when i have a bunch more time to spend.

gruehle · 2013-06-02T01:34:56Z

@WebsiteDeveloper - I put up pull request #4054, which supersedes this pull request. It has all of your commits here, plus an upgrade to jQuery 2.0.1. Thanks again for all of your help with this!

WebsiteDeveloper added 13 commits May 26, 2013 13:02

Updated bootstrap to 2.3.1 and less to 1.3.3 (needed for bootstrap)

ff8d55c

Fixed Context Menu

54394b0

Three more migration fixes

6c23c49

Fixed a few UI issues and removed unused responsive files

de6c29d

Fixed missed log statement

b276e04

Fix scroller-shadow

ceb6297

Fix install extensions unit tests

c21ab02

Fixed find and JSLint UI

b34eb06

Fixed modal layout issues

ceca9bc

Fix for menu positioning

ad63c37

explicitly set margin-top to 0

Parsed LESS to CSS and load the css file

c58b5e6

I added this because somehow the relative path of the WebPlatform logo isn't found.

Moved dropdown menu styles to fix recent projects UI

026f9dd

Added data-button-id to the dialog templates

9c6a57e

Fixes for ContextMenus and Dialogs

43d5435

+ one UI fix

gruehle reviewed May 28, 2013
View reviewed changes

gruehle mentioned this pull request May 29, 2013

LESS CSS versoin upgrade to 1.3.3 #4017

Closed

Fixes after review

c04cf47

gruehle closed this Jun 2, 2013

core-ai-bot mentioned this pull request Aug 29, 2021

[CLOSED] [ARCH] Updated bootstrap to 2.3.1 and less to 1.3.3 (needed for bootstrap) brackets-archive/bracketsIssues#3720

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ARCH] Updated bootstrap to 2.3.1 and less to 1.3.3 (needed for bootstrap) #3996

[ARCH] Updated bootstrap to 2.3.1 and less to 1.3.3 (needed for bootstrap) #3996

WebsiteDeveloper commented May 26, 2013

TuckerWhitehouse commented May 26, 2013

WebsiteDeveloper commented May 26, 2013

WebsiteDeveloper commented May 26, 2013

TuckerWhitehouse commented May 26, 2013

gruehle May 28, 2013

redmunds May 28, 2013

WebsiteDeveloper May 28, 2013

gruehle May 28, 2013

WebsiteDeveloper May 29, 2013

gruehle commented May 28, 2013

gruehle commented May 28, 2013

njx commented May 28, 2013

gruehle May 28, 2013

dangoor commented May 30, 2013

WebsiteDeveloper commented May 30, 2013

WebsiteDeveloper commented May 30, 2013

gruehle commented May 30, 2013

WebsiteDeveloper commented May 31, 2013

dangoor commented May 31, 2013

njx commented May 31, 2013

DennisKehrig commented May 31, 2013

njx commented May 31, 2013

gruehle commented May 31, 2013

WebsiteDeveloper commented Jun 1, 2013

gruehle commented Jun 2, 2013

		@@ -7,6 +7,6 @@ <h1 class="dialog-title">{{EXTENSION_MANAGER_TITLE}}</h1>
		<div class="modal-body no-padding zebra-striped"></div>

[ARCH] Updated bootstrap to 2.3.1 and less to 1.3.3 (needed for bootstrap) #3996

[ARCH] Updated bootstrap to 2.3.1 and less to 1.3.3 (needed for bootstrap) #3996

Conversation

WebsiteDeveloper commented May 26, 2013

TuckerWhitehouse commented May 26, 2013

WebsiteDeveloper commented May 26, 2013

WebsiteDeveloper commented May 26, 2013

TuckerWhitehouse commented May 26, 2013

gruehle May 28, 2013

Choose a reason for hiding this comment

redmunds May 28, 2013

Choose a reason for hiding this comment

WebsiteDeveloper May 28, 2013

Choose a reason for hiding this comment

gruehle May 28, 2013

Choose a reason for hiding this comment

WebsiteDeveloper May 29, 2013

Choose a reason for hiding this comment

gruehle commented May 28, 2013

gruehle commented May 28, 2013

njx commented May 28, 2013

gruehle May 28, 2013

Choose a reason for hiding this comment

dangoor commented May 30, 2013

WebsiteDeveloper commented May 30, 2013

WebsiteDeveloper commented May 30, 2013

gruehle commented May 30, 2013

WebsiteDeveloper commented May 31, 2013

dangoor commented May 31, 2013

njx commented May 31, 2013

DennisKehrig commented May 31, 2013

njx commented May 31, 2013

gruehle commented May 31, 2013

WebsiteDeveloper commented Jun 1, 2013

gruehle commented Jun 2, 2013