This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Hack yet another place where we need to use _codeMirror.replaceRange()... #3711
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) in code hints to make them work in inline editors because of #1688.
ghost
assigned
Author
|
/cc @dangoor, just FYI as something to watch out for in code hint providers. @adrocknaphobia -- we should really bring the "migrate to CodeMirror doc-linking" story (https://trello.com/c/cRAl0YHB) higher on the backlog to fix this issue once and for all... |
Contributor
|
yeah, I think this is the only place we do replaceRange. Merging |
eztierney
added a commit
that referenced
this pull request
May 3, 2013
Hack yet another place where we need to use _codeMirror.replaceRange()...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...in code hints to make them work in inline editors because of #1688. Sigh.
Fixes #3709.
To @eztierney for review. It looks like this is the single place where JS code hints actually edits the document, so I think this is the only place we have to patch this up. Let me know if there's another place we might have to do this fix.