Added EntityHints unit tests #3524
Conversation
ghost
assigned 
| }); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Nit: please add newline at end of file
|
Done with initial code review. This looks good. Some suggestions for a few more tests, and a few nits. |
|
@redmunds changes pushed. |
|
@redmunds fixes pushed. |
| <!-- Should show multiple hints in same line --> | ||
| <p>This & that & the other</p> | ||
|
|
||
| <!-- Shouldn't show hints when entity on the same line--> |
There was a problem hiding this comment.
(moving this comment from commit to pull request).
This test should be: "Should show HTML hints after HTML Entity on same line".
|
@WebsiteDeveloper Sorry for commenting on the commit. Done with review. |
|
@redmunds fixes pushed. |
| }); | ||
|
|
||
| //Test for issue #3339 | ||
| it("should show HTML hints after HTML Entity on same line", function () { |
There was a problem hiding this comment.
This should test that HTML (property) code hints are showing, as opposed to HTML Entity code hints are not showing. But, since HTMLCodeHints are implemented as an extension, there's no guarantee that they will exist, so you can't test that here. That test needs to be done in the HTMLCodeHints extension, so this test should be removed. Sorry for the confusion.
|
@WebsiteDeveloper Done with review. |
|
@redmunds remove the test. |
|
@redmunds put up a pull to add the test to HTMLCodeHints in case you want to do a quick review. |
|
Looks good. Merging. |
No description provided.