This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Breaks out package validation for sharing with brackets-registry #3261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation code is no longer in ExtensionManagerDomain itself.
For the extension registry, we want package.json to be required. With this change, the validation code allows optional checking for package.json.
ghost
assigned
|
Reviewing. |
There was a problem hiding this comment.
I wonder if we should include a files attribute that only includes the files we intend to share with the registry server. The answer is probably "no"...but was just wondering what you were thinking about it.
Contributor
Author
There was a problem hiding this comment.
Yeah, I was thinking it's not worth bothering with. Maybe if we start having a lot more code that is Brackets-client specific.
|
Merging--the comments were just for minor information and can be addressed later. |
njx
pushed a commit
that referenced
this pull request
Mar 27, 2013
Breaks out package validation for sharing with brackets-registry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we can use
npm packto create a package that we can install into the brackets-registry project as a simple way to share this bit of code.